Skip to content

fix(compliance): surface stripped request field notices#5500

Open
sangilish wants to merge 2 commits into
adcontextprotocol:mainfrom
sangilish:codex/fix-runner-field-stripping-5495
Open

fix(compliance): surface stripped request field notices#5500
sangilish wants to merge 2 commits into
adcontextprotocol:mainfrom
sangilish:codex/fix-runner-field-stripping-5495

Conversation

@sangilish

Copy link
Copy Markdown
Contributor

Summary

  • Register input_schema_field_stripped as a canonical info-level runner notice code.
  • Add advisory filter-effectiveness checks to the creative-template filter_by_type storyboard for max width/height filtering.
  • Add an empty changeset for the compliance contract update.

Refs #5495.

Notes

This covers the adcp compliance/spec half of #5495. The runner still needs a sibling adcp-client change so stripped request fields are emitted in structured JSON rather than console-only output.

Validation

  • npm run build:compliance
  • npm run test:storyboard-check-enum
  • npm run test:storyboard-advisory-expiry
  • npm run test:storyboard-validations-paths
  • npx prettier --check static/compliance/source/specialisms/creative-template/index.yaml .changeset/runner-field-stripping-notice.md
  • git diff --check
  • commit hook precommit suite
  • push hook storyboard matrix for current compliance source and 3.0 compatibility

@aao-release-bot aao-release-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45b10f0db4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +204 to +207
- check: field_less_than
path: "formats[*].renders[*].dimensions.width"
value: 729
description: "Advisory: formats returned for max_width 728 should not exceed that width"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve any-render semantics for dimension filters

For multi-render formats, the published list_creative_formats docs define max_width/max_height as matching when at least one render fits, and explicitly allow larger companion pieces. This validation resolves formats[*].renders[*].dimensions.width and requires every returned render to be below 729 (with the height check below doing the same), so a compliant format such as a 1920×1080 video with a 728×90 companion would be reported as an advisory problem even though it should pass the filter.

Useful? React with 👍 / 👎.

@aao-release-bot aao-release-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant