fix(compliance): surface stripped request field notices#5500
Conversation
There was a problem hiding this comment.
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.
This is an automated message from the Argus AI review workflow.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45b10f0db4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - check: field_less_than | ||
| path: "formats[*].renders[*].dimensions.width" | ||
| value: 729 | ||
| description: "Advisory: formats returned for max_width 728 should not exceed that width" |
There was a problem hiding this comment.
Preserve any-render semantics for dimension filters
For multi-render formats, the published list_creative_formats docs define max_width/max_height as matching when at least one render fits, and explicitly allow larger companion pieces. This validation resolves formats[*].renders[*].dimensions.width and requires every returned render to be below 729 (with the height check below doing the same), so a compliant format such as a 1920×1080 video with a 728×90 companion would be reported as an advisory problem even though it should pass the filter.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.
This is an automated message from the Argus AI review workflow.
Summary
input_schema_field_strippedas a canonical info-level runner notice code.filter_by_typestoryboard for max width/height filtering.Refs #5495.
Notes
This covers the
adcpcompliance/spec half of #5495. The runner still needs a siblingadcp-clientchange so stripped request fields are emitted in structured JSON rather than console-only output.Validation
npm run build:compliancenpm run test:storyboard-check-enumnpm run test:storyboard-advisory-expirynpm run test:storyboard-validations-pathsnpx prettier --check static/compliance/source/specialisms/creative-template/index.yaml .changeset/runner-field-stripping-notice.mdgit diff --check