test(logging): add tests for FilteredLogger message discard#43
test(logging): add tests for FilteredLogger message discard#43adcondev wants to merge 4 commits into
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
⚡ Benchmark ResultsTo add benchmarks, create functions starting with |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…ckages Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Signed-off-by: Adrián Constante <ad_con.reload@proton.me>
🎯 What: Added unit tests for FilteredLogger's message discarding mechanism to ensure it behaves correctly when verbose mode is on/off.
📊 Coverage: Added tests covering verbose=true/false scenarios, testing discarding of non-critical messages, and testing preservation of critical messages. Also refactored FilteredLogger to take an io.Writer instead of an *os.File to make testing simpler without actual files.
✨ Result: Increased test coverage for the logging package, ensuring correct log filtering behavior.
PR created automatically by Jules for task 11542656801431102939 started by @adcondev