Skip to content

test(logging): add tests for FilteredLogger message discard#43

Open
adcondev wants to merge 4 commits into
masterfrom
test/logging-filtered-logger-11542656801431102939
Open

test(logging): add tests for FilteredLogger message discard#43
adcondev wants to merge 4 commits into
masterfrom
test/logging-filtered-logger-11542656801431102939

Conversation

@adcondev
Copy link
Copy Markdown
Owner

@adcondev adcondev commented Jun 1, 2026

🎯 What: Added unit tests for FilteredLogger's message discarding mechanism to ensure it behaves correctly when verbose mode is on/off.
📊 Coverage: Added tests covering verbose=true/false scenarios, testing discarding of non-critical messages, and testing preservation of critical messages. Also refactored FilteredLogger to take an io.Writer instead of an *os.File to make testing simpler without actual files.
Result: Increased test coverage for the logging package, ensuring correct log filtering behavior.


PR created automatically by Jules for task 11542656801431102939 started by @adcondev

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

⚡ Benchmark Results

⚠️ No benchmarks found in the current codebase.

To add benchmarks, create functions starting with Benchmark in *_test.go files.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 13.63636% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/logging/logging.go 21.42% 11 Missing ⚠️
internal/logging/rotation.go 0.00% 6 Missing ⚠️
internal/auth/auth.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

…ckages

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@github-actions github-actions Bot added size/M and removed size/S labels Jun 1, 2026
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@adcondev adcondev changed the title 🧪 test(logging): add tests for FilteredLogger message discard test(logging): add tests for FilteredLogger message discard Jun 1, 2026
Signed-off-by: Adrián Constante <ad_con.reload@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants