Run rustfmt on both manifests; main's fmt gate has been red since #67 - #71
Merged
Conversation
…nce #67 cargo fmt --all fails on main, in both cargo workspaces, and has since #67 merged on 2026-09-06. #68 added more. Both are mine. The reason it went unnoticed is worth recording: "fmt + clippy" is not a REQUIRED status check on this repo - only "cargo test (workspace)" is - so a red fmt does not block a merge. Three PRs merged past a failing gate without anyone choosing to override it. That is exactly I1's corollary from the doctrine side, arriving from the other direction: a check that cannot block is not a gate. It ran, it failed, and the merge happened anyway. No logic changes. rustfmt's own preferences only: server.rs import moved to its sorted position dashboard.rs two chained expressions wrapped Clippy is clean on both manifests with -D warnings, and was already. Tests unchanged: 90 fleetd + 30 fleet-core. Recommend making "fmt + clippy" required alongside "cargo test", so this class of drift cannot land again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --allfails onmainin both cargo workspaces, and has since #67 merged on 2026-09-06. #68 added more. Both are mine.Why it went unnoticed is the interesting part
fmt + clippyis not a required status check on this repo — onlycargo test (workspace)is. So a red fmt doesn't block a merge, and three PRs merged past a failing gate without anyone choosing to override it.That is I1's corollary arriving from the other direction: a check that cannot block is not a gate. It ran, it failed, and the merge happened anyway. Same shape as the Announce gate and
parse_blockers— the fourth instance this week.Changes
No logic. rustfmt's own preferences only:
crates/fleetd/src/server.rs— import moved to its sorted positioncockpit/ui/src-tauri/src/dashboard.rs— two chained expressions wrappedClippy is clean on both manifests with
-D warnings, and already was. Tests unchanged: 90 fleetd + 30 fleet-core.Recommendation
Make
fmt + clippyrequired alongsidecargo test, so this class of drift can't land again. One settings change; I can't make it from here.