Make FlowDTO.status and PlacementSummaryDTO.is_active optional - #28
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mlnchk
force-pushed
the
fix/optional-dto-fields
branch
from
September 10, 2026 11:25
3df1940 to
1571b34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type-only change to match a Developer API hotfix. No runtime behavior change — the CLI renders whatever the API returns via
printResponse, which skips absent fields.What
In
src/lib/api-schemas.ts:FlowDTO.status→ optional.flows updateno longer returns it; get/list/create/publish still do.PlacementSummaryDTO.is_active→ optional. The paywall placements endpoint omits it; placements list/get still return it.The parallel
FlowConfigDTO.statusandPlacementDetailDTO.is_activestay required, since those responses still carry the fields.Verify
pnpm build && pnpm test && pnpm lint && pnpm run check:agent-docs— all green (203 tests passing).