Conversation
taylortom
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17
Fix
releasejob, so the job inherits whatever the calling workflow grants. Callers that follow the documented permissions block can start again; callers publishing to GitHub Packages keep working by grantingpackages: writethemselves.packages: write"even though the reusable workflow declares it". The reusable workflow no longer declares it.Background
packages: writewas added to the job in #9 so GitHub Packages publishing would work. GitHub does not let a called workflow's job request more permissions than the caller grants, so every caller using the four documented permissions was rejected before any job was scheduled, with a startup failure and no logs. adapt_framework has not released since 13 April 2026 for this reason.Testing
masterin adapt_framework, whose caller grantscontents,issues,pull-requestsandid-tokenonly. The Release job should now start and run semantic-release, rather than ending as a startup failure.packages: writein addition still publishes successfully.Note
The job permissions block was added in b54bf20 to satisfy a code scanning alert about a workflow without a permissions block. That alert may reappear for this file and need dismissing, since a reusable workflow cannot safely pin its own permissions.
Posted via collaboration with Claude Code