Skip to content

Remove broken common submodule pre-build workaround#2

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-compile-error-missing-library
Draft

Remove broken common submodule pre-build workaround#2
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-compile-error-missing-library

Conversation

Copilot AI commented May 12, 2026

Copy link
Copy Markdown

The previous change assumed the firmware could recover missing shared headers by initializing a common/ git submodule during the PlatformIO pre-build step. Based on follow-up feedback, that submodule reference is not valid for this repository, so the workaround has been removed.

  • Reverted build-script behavior

    • Removed the added common/ submodule initialization logic from scripts/gen_version.py.
    • Restored the pre-build script to its original version-generation-only behavior.
  • Source reference investigation

    • Verified that the remaining compile issue is due to unresolved in-repository header/module references rather than a recoverable submodule checkout step.
    • Identified missing project-local references from src/, including:
      • conn_log.h
      • net_console.h
      • tc_hmi.h
      • tcc_pinmap.h
      • cmd_gpio.h
      • cmd_pwm.h
      • cmd_adc.h
      • cmd_i2c.h
      • cmd_wifi.h
      • cmd_ota.h
      • cmd_uart.h
      • cmd_swd.h
      • cmd_mqtt.h
      • cmd_statemachine.h
      • tc_statemachine.h
      • tc_mqtt.h
  • Scope

    • No firmware logic changes.
    • No new dependency-handling behavior.
    • Focused on removing the invalid submodule workaround and documenting the actual missing source references now blocking compilation.

[!WARNING]

Copilot AI linked an issue May 12, 2026 that may be closed by this pull request
Copilot AI changed the title [WIP] Fix compilation error due to missing library Initialize required common submodule during PlatformIO pre-build May 12, 2026
Copilot AI requested a review from adamj537 May 12, 2026 11:26

@adamj537 adamj537 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodule linked to this project does not exist. Please remove the reference to the submodule, and instead try to find any missing function references between the source files.

Copilot AI commented May 16, 2026

Copy link
Copy Markdown
Author

The submodule linked to this project does not exist. Please remove the reference to the submodule, and instead try to find any missing function references between the source files.

Removed the submodule-based prebuild logic in e42b7c4. I also checked the repo for in-tree missing references and the unresolved project-local modules I could confirm are conn_log.h/conn_log_init/register_conn_log_commands, net_console.h/net_console_start, tc_hmi.h/tc_hmi_init/tc_hmi_start, tcc_pinmap.h, plus the absent command/state-machine headers referenced from src/ such as cmd_gpio.h, cmd_pwm.h, cmd_adc.h, cmd_i2c.h, cmd_wifi.h, cmd_ota.h, cmd_uart.h, cmd_swd.h, cmd_mqtt.h, cmd_statemachine.h, tc_statemachine.h, and tc_mqtt.h.

Copilot AI changed the title Initialize required common submodule during PlatformIO pre-build Remove broken common submodule pre-build workaround May 16, 2026
Copilot AI requested a review from adamj537 May 16, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not compile

2 participants