Suggest check_concurrency when status reports an incorrect quantity - #40
Open
facundofarias wants to merge 1 commit into
Open
facundofarias wants to merge 1 commit into
facundofarias wants to merge 1 commit into
Conversation
`procodile status` reports when a process type is below its configured
quantity:
* worker only has 23 instances (should have 25)
but does not say how to fix it. The remedy is `procodile check_concurrency`,
which is easy to miss: `procodile start <type>` looks like the obvious
candidate but is a no-op here, because start_processes skips any type that
already has running instances.
Print a follow-up line naming the command whenever an incorrect_quantity
message is present.
This is deliberately added to StatusCLIOutput rather than Message.parse,
because Message.parse also backs `procodile status --simple`, whose one-line
output is typically consumed by monitoring and should stay terse.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01P89F451YDRDBj5br14i3GD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
procodile statustells you when a process type is below its configured quantity:but not what to do about it. The remedy is
procodile check_concurrency, which is easy to miss —procodile start workerlooks like the obvious candidate, but it is a no-op here, becauseSupervisor#start_processesskips any type that already has running instances:We hit this on a production host that had been sitting at 23/25 workers for weeks. The warning was visible in
statusthe whole time; nobody acted on it because it didn't say what would fix it, and the command people reached for did nothing.Change
Print a follow-up line naming the command whenever an
incorrect_quantitymessage is present:Notes
Added to
StatusCLIOutputrather thanMessage.parsedeliberately —Message.parsealso backsprocodile status --simple, whose one-line output is typically consumed by monitoring and should stay terse.--simpleis unchanged.Specs added in
spec/specs/status_cli_output_spec.rbcovering the quantity case, the non-quantity case, no messages, and mixed messages. Full suite green (39 examples).