rotaryio.IncrementalEncoder deinit fix and improvements#10634
Merged
tannewt merged 1 commit intoadafruit:mainfrom Sep 17, 2025
Merged
rotaryio.IncrementalEncoder deinit fix and improvements#10634tannewt merged 1 commit intoadafruit:mainfrom
tannewt merged 1 commit intoadafruit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raspberrypirotaryio.IncrementalEncoder, make object be marked as deinited if constructor fails.rotaryio.IncrementalEncoderimplementations, implement and usecommon_hal_rotaryio_incrementalencoder_mark_deinit()consistently and same forrp2pio.StateMachine.Note that in some previous implementations, both IncrementalEncoder pins were
NULL'd out on deinit. This was not really necessary, because the deinit test just checks that one of the pins isNULL, which is good enough.I tested on RP2040 to show that bug no longer occurs. Also tested
StateMachinedeinit()still works.I also tested on all other ports that implement
rotaryiothat creation and deinit ofIncrementalEncoderstill works:atmel-samd,espressif,nordic,mimxrt10xx.@Hagtronics FYI