DRAFT: attempt to fix USB crash for CIRCUITPY access + rapid read() polling#10626
Closed
samblenny wants to merge 1 commit intoadafruit:mainfrom
Closed
DRAFT: attempt to fix USB crash for CIRCUITPY access + rapid read() polling#10626samblenny wants to merge 1 commit intoadafruit:mainfrom
samblenny wants to merge 1 commit intoadafruit:mainfrom
Conversation
This attempts to fix a problem where a Fruit Jam board crashes if you access the CIRCUITPY drive while it's rapidly polling a gamepad using usb.core.Device.read(). The fix is incomplete.
tannewt
requested changes
Sep 10, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
I don't want to do this. It is TinyUSB's job to ensure it is in a good state to handle a read() call.
Author
|
Okay. Sounds reasonable. I'll leave this for you or Thach to sort out then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix a problem where a Fruit Jam board crashes if you access the CIRCUITPY drive while
code.pyis rapidly polling a gamepad usingusb.core.Device.read(). For details on the problem seeThis fix is only marginally effective. It's still kinda crashy, but marginally less so than without the changes. I'm posting this here so people can poke at the code or try the CI build if they want.