sdkconfig.defaults: use standard defaults#10609
Merged
tannewt merged 1 commit intoadafruit:mainfrom Sep 3, 2025
Merged
Conversation
|
@dhalbert were you able to reproduce the initial problem and then verify that this fixed it? If not, I could probably build & test this on a Lolin S2 or S3 mini |
Collaborator
Author
|
Yes, I reproduced the problem easily with the test program in #10606, and verified this fixes it. |
anecdata
reviewed
Sep 3, 2025
Member
anecdata
left a comment
There was a problem hiding this comment.
Tested with the minimal example, and with an async example with 2-3 servers and the remainder of the sockets as clients, and all of the connections get made. Thanks, Dan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some lower-valued LWIP settings in
sdkconfig.defaultson espressif. In particular, removed:These settings restricted the number of usable sockets. It looks like LWIP might have started paying more attention to these when it was updated in in ESP-IDF 5.4.1.
These were all removed:
Reading
Kconfig, it appears the defaults were reasonable, and we might get better performance using the defaults (which are computed in some cases).Thanks @anecdata for the issue and for the clue re the
CONFIG_LWIP_MAX...settings.