Scale current duration when MidiTrack.tempo is set#10579
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Aug 22, 2025
Merged
Scale current duration when MidiTrack.tempo is set#10579dhalbert merged 1 commit intoadafruit:mainfrom
MidiTrack.tempo is set#10579dhalbert merged 1 commit intoadafruit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor bug fix for the changes introduced in #10567.
When adjusting the tempo on a MidiTrack source that is actively playing, the current note (or pause) is set to a duration defined by the previous tempo value until it runs out and a new note (or pause) is played and the duration is recalculated. This can cause de-synchronization if two MidiTrack sources are playing concurrently.
This update simply scales the remaining duration (which is decremented with each sample) so that it is adjusted to the new tempo value.
The following example demonstrates this issue. The two tracks will eventually begin to drift away from each other while their tempo set to a random value every 2 seconds. After the update, they will remain in synchronization. This example is written for the Adafruit Fruit Jam using the onboard speaker.