Restore audioio on ESP32 and ESP32-S2#10578
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Aug 22, 2025
Merged
Conversation
FoamyGuy
approved these changes
Aug 22, 2025
Collaborator
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Makes sense, and looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
CIRCUITPY_AUDIOIO ?= 1as the default, then turn it off for chips that don't have it withCIRCUITPY_AUDIOIO = 0. That way, it can also be turned off selectively as needed.Also add some prominent comments to fence the choices for each chip type, to make it easier to find a particular chip's settings.
Also conditionalize
CIRCUITPY_ALARM_TOUCHas being dependent onCIRCUITPY_ALARMon boards that support it.Tested on Metro ESP32-S2 that
import audioioworks.