-
Notifications
You must be signed in to change notification settings - Fork 1
Kll #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: zig-build
Are you sure you want to change the base?
Kll #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,6 +157,7 @@ LIBSSH_4_5_0 # Released | |
| ssh_channel_poll; | ||
| ssh_channel_poll_timeout; | ||
| ssh_channel_read; | ||
| ssh_channel_read_buffered; | ||
| ssh_channel_read_nonblocking; | ||
| ssh_channel_read_timeout; | ||
| ssh_channel_request_auth_agent; | ||
|
|
@@ -223,6 +224,7 @@ LIBSSH_4_5_0 # Released | |
| ssh_get_log_userdata; | ||
| ssh_get_openssh_version; | ||
| ssh_get_poll_flags; | ||
| ssh_session_handle_poll; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This change adds Useful? React with 👍 / 👎. |
||
| ssh_get_pubkey; | ||
| ssh_get_pubkey_hash; | ||
| ssh_get_publickey; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
ssh_channel_read_buffered, the closed-state branch is evaluated before the EOF branch. A normal remote close path setsremote_eof = 1and may setstate = SSH_CHANNEL_STATE_CLOSEDwhen buffers are empty, so this function reportsSSH_ERROR(and a fatal error message) instead ofSSH_EOFfor graceful shutdown. That contradicts this API's contract and causes event-loop/nonblocking callers to mis-handle normal channel termination as a hard failure.Useful? React with 👍 / 👎.