Fixed bug in #2887#2920
Closed
sydow wants to merge 2 commits into
Closed
Conversation
Contributor
|
@sydow FYI, I converted this PR to draft to block it for the time being. I have started the work on converting for project-prefixes, so there will be CI job failures here. This PR will have to wait. I'll let you know once it is done :) |
Contributor
|
Closing in preference of #2927 which is rebased on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #2887, which was merged a week ago contained a bug which allowed methods which were not methods of an ancestor protocol to fill empty slots. This PR corrects this.