Skip to content

fix: 快捷审核详情隐藏 SQL 条数与涉及 SQL #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordofAvernus merged 2 commits into from
Sep 30, 2026
Merged

fix: 快捷审核详情隐藏 SQL 条数与涉及 SQL #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72b3b9f
fix(ui): hide SQL count and involved-SQL on audit detail
LordofAvernus Sep 29, 2026
4fc6691
chore(ui): refresh branch version stamp and VersionModal snapshots
LordofAvernus Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...v/SideMenu/UserMenu/Modal/VersionModal/test/__snapshots__/BasicVersionModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ exports[`base/Nav/SideMenu/UserMenu/BasicVersionModal render snap when open is t
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down Expand Up @@ -345,7 +345,7 @@ exports[`base/Nav/SideMenu/UserMenu/BasicVersionModal render snap when open is t
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down
4 changes: 2 additions & 2 deletions ...c/page/Nav/SideMenu/UserMenu/Modal/VersionModal/test/__snapshots__/index.ce.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ exports[`base/Nav/SideMenu/UserMenu/VersionModal-ce render snap when open is tru
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down Expand Up @@ -1312,7 +1312,7 @@ exports[`base/Nav/SideMenu/UserMenu/VersionModal-ce render snap when open is tru
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down
4 changes: 2 additions & 2 deletions .../src/page/Nav/SideMenu/UserMenu/Modal/VersionModal/test/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ exports[`base/Nav/SideMenu/UserMenu/VersionModal-ee render snap when open is tru
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down Expand Up @@ -352,7 +352,7 @@ exports[`base/Nav/SideMenu/UserMenu/VersionModal-ee render snap when open is tru
class="ant-typography css-dev-only-do-not-override-txh9fw"
>
UI:
dev-zjrc-user-system-admin f4fab7b02
dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876
</article>
</div>
<div
Expand Down
3 changes: 2 additions & 1 deletion packages/base/src/scripts/version.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export const UI_VERSION = 'dev-zjrc-user-system-admin f4fab7b02';
export const UI_VERSION =
'dev-zjrc-sql-audit-report-rule-hit-count-20260929 bbff01876';
9 changes: 0 additions & 9 deletions packages/sqle/src/page/SqlAudit/Detail/LevelHitSummary/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const LevelHitSummary = ({
const warnCount = toCount(levelSummary?.warn_count);
const noticeCount = toCount(levelSummary?.notice_count);
const normalCount = toCount(levelSummary?.normal_count);
const sqlCount = toCount(levelSummary?.sql_count);
const errorPriorityParts = [
errorP0 > 0 ? `P0 ${errorP0}` : '',
errorP1 > 0 ? `P1 ${errorP1}` : ''
Expand Down Expand Up @@ -92,14 +91,6 @@ const LevelHitSummary = ({
{t('components.auditResultMessage.level.normal')}
<span className="level-hit-value">{normalCount}</span>
</span>
<span
className="level-hit-item"
data-testid="sql-audit-level-hit-sql-count"
data-value={sqlCount}
>
{t('sqlAudit.detail.levelHitSummary.sqlCount')}
<span className="level-hit-value">{sqlCount}</span>
</span>
</div>
)}
</LevelHitSummaryStyleWrapper>
Expand Down
5 changes: 0 additions & 5 deletions packages/sqle/src/page/SqlAudit/Detail/RuleHitDetails/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ const RuleHitDetails = ({
<th>{t('sqlAudit.detail.ruleHitDetails.columns.level')}</th>
<th>{t('sqlAudit.detail.ruleHitDetails.columns.hitCount')}</th>
<th>{t('sqlAudit.detail.ruleHitDetails.columns.message')}</th>
<th>{t('sqlAudit.detail.ruleHitDetails.columns.sqlNumbers')}</th>
</tr>
</thead>
<tbody>
Expand All @@ -68,9 +67,6 @@ const RuleHitDetails = ({
Number.isFinite(item.hit_count)
? item.hit_count
: 0;
const sqlNumbers = (item.sql_numbers ?? [])
.map((n) => `#${n}`)
.join(', ');
const rowKey = `${item.rule_name ?? displayName}-${index}`;

return (
Expand All @@ -84,7 +80,6 @@ const RuleHitDetails = ({
{hitCount}
</td>
<td>{(item.message ?? '').trim() || EMPTY}</td>
<td>{sqlNumbers || EMPTY}</td>
</tr>
);
})}
Expand Down
12 changes: 0 additions & 12 deletions packages/sqle/src/page/SqlAudit/Detail/__snapshots__/index.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,18 +232,6 @@ exports[`sqle/SqlAudit/Detail should match snap shot 1`] = `
0
</span>
</span>
<span
class="level-hit-item"
data-testid="sql-audit-level-hit-sql-count"
data-value="0"
>
SQL 条数
<span
class="level-hit-value"
>
0
</span>
</span>
</div>
</div>
<div
Expand Down
Loading