fix: find the exported engine next to the source model - #135
Open
gh-underfoot581 wants to merge 1 commit into
Open
fix: find the exported engine next to the source model#135gh-underfoot581 wants to merge 1 commit into
gh-underfoot581 wants to merge 1 commit into
Conversation
Ultralytics writes the .engine beside the .pt it exported, which is not always the output directory the caller asked for. Only that directory was checked, so a perfectly good export was reported as "No engine file was created". Check beside the model too, and move the file into the output directory when it turns up there. The failure message now names both paths it looked in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultralytics writes the
.enginenext to the.ptit exported, which is not always theoutput_dirpassed in. Onlyoutput_dirwas checked, so a successful export could be reported asNo engine file was createdwhile the engine sat beside the model.I hit this on Windows with an NVIDIA GPU: the export ran to completion and was still reported as producing nothing.
I also called
export_model()directly withultralytics.YOLO.exportstubbed to write the.enginebeside the.pt:success=False, "No engine file was created"success=True, engine moved into output_dirsuccess=Truesuccess=True, unchangedsuccess=Falsesuccess=False, message names both paths checked