fix: show the export output when a TensorRT export fails - #134
Open
gh-underfoot581 wants to merge 1 commit into
Open
fix: show the export output when a TensorRT export fails#134gh-underfoot581 wants to merge 1 commit into
gh-underfoot581 wants to merge 1 commit into
Conversation
The export subprocess is started with stderr=subprocess.STDOUT, so the stderr handed back is always empty and every failure surfaces as "Export failed:" with nothing after it. Report stdout instead, which carries the merged output. The JSON branch gets the same treatment: the export script already puts a traceback in its result, it was just never read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed TensorRT export reports
Export failed:with nothing after it._run_export_subprocessstarts the subprocess withstderr=subprocess.STDOUT(line 526), so thestderrit hands back is always empty.stdout, which carries the merged output, on a non-zero exitThis came out of chasing an export that kept failing with an empty message on Windows with an NVIDIA GPU. Seeing the actual error is what made the underlying problem findable.