Skip to content

fix: keep the file dialog at the size the user left it #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gh-underfoot581 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: keep the file dialog at the size the user left it #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion application/classes/file_dialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ def __init__(self, app_logic_instance) -> None:
self.overwrite_file_path: str = ""
self.video_extensions = ['.mp4', '.mkv', '.avi', '.mov', '.wmv', '.flv', '.webm']

# Dialog size, restored on open and saved on close
self._window_width: int = 750
self._window_height: int = 400
self._size_initialized: bool = False

# Cached directory listing and metadata to avoid per-frame filesystem hits
self._current_dir_cached: str = ""
self._cached_directories: list[str] = []
Expand Down Expand Up @@ -151,9 +156,19 @@ def show(
if initial_path and os.path.isdir(initial_path):
self.current_dir = initial_path

self._window_width = self.app.app_settings.get("file_dialog_width", 750)
self._window_height = self.app.app_settings.get("file_dialog_height", 400)
self._size_initialized = False

# Invalidate caches on open
self._invalidate_listing_cache()

def _save_window_size(self) -> None:
"""Remembers the dialog size so the next open matches this one."""
width, height = imgui.get_window_size()
self.app.app_settings.set("file_dialog_width", int(width))
self.app.app_settings.set("file_dialog_height", int(height))

def _invalidate_listing_cache(self) -> None:
self._current_dir_cached = ""
self._cached_directories = []
Expand Down Expand Up @@ -311,10 +326,13 @@ def draw(self) -> None:
if not self.open:
return

imgui.set_next_window_size(750, 400)
if not self._size_initialized:
imgui.set_next_window_size(self._window_width, self._window_height)
self._size_initialized = True
is_open_current_frame, self.open = imgui.begin(self.title, self.open)

if not self.open:
self._save_window_size()
imgui.end()
return

Expand All @@ -336,6 +354,8 @@ def draw(self) -> None:
self._draw_overwrite_confirm()
finally:
imgui.columns(1)
if not self.open:
self._save_window_size()
imgui.end()

def _draw_directory_navigation(self) -> None:
Expand Down