Key patched materials by injection source - #8
Open
kvnloo wants to merge 1 commit into
Open
Conversation
three.js caches programs on onBeforeCompile.toString(). Wrappers from patchOnBeforeCompile are identically worded, so later patches reused the first compiled program. customProgramCacheKey now includes fn source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
three.js caches programs on
onBeforeCompile.toString().patchOnBeforeCompilewrappers are identically worded, so later injections reused the first compiled program (wrong uniforms, black frames).customProgramCacheKeynow includes the injection source, composed down the chain.Pin:
node --experimental-default-type=module --test src/utils/shaderPatch.test.jsSHA:
e86480de37425245c3b1bf2719e4d60a53996a57No origin issue. Origin target: achrefelouafi/LinearAbiltyCastingThreeJS (do not open until Linear HITL is Done).