Supersede #58: rebase 3-tier preview on main + runtime/CI/doc fixes#63
Open
Supersede #58: rebase 3-tier preview on main + runtime/CI/doc fixes#63
Conversation
Sponsored docker compose preview version. Agentic Coding Fixed to dockerize the frontend container. Startet dokumentation change (not finished yet)
…rated to queries/apiClient)
… adding login page
- remove invalid frontend image COPY of /staticfiles paths that are outside frontend build context - proxy /static/ via frontend nginx to backend in preview mode - stop running makemigrations at container startup; keep migrate only for deterministic schema - add RUNNER_UID/GID defaults in preview compose to improve first-run reliability - run gunicorn in Dockerfile prod stage with LOG_LEVEL default expansion - switch docker-compose.ci.yml build target to prod so CI validates production-like runtime Reasoning: These changes remove non-deterministic startup behavior and fix a concrete preview build failure, while making CI exercise the same runtime model used for production deployment.
- update quick-start API/static expectations for 3-tier preview - document REACT_APP_API_URL same-origin proxy behavior - clarify makemigrations is a manual dev workflow, not container startup - point dev installation guide to docker-compose-preview.yml - ignore generated backend/staticfiles artifacts
xMinhx
added
bug
Collaborator
Greenpepper15
left a comment
Greenpepper15
left a comment
There was a problem hiding this comment.
Ich habe mir das mal mit AI angeguckt und diese Punkte schienen für mich relevant.
Ich habe die APP auch mal ausprobiert. Die Kern Funktionalitäten haben bei mir auch geklappt.
- Remove debug console statements that logged passwords (LoginBox.tsx)
- Translate German comments to English (LoginBox.tsx)
- Add GET method with @ensure_csrf_cookie to Login view; remove validate_email from username check
- Restore deleted backend/assets/icons/ and backend/assets/images/ (eye.svg, logos, flags, etc.)
- Add set -e to entrypoint.sh
- Fix FQDN https check to use startswith("https://") instead of substring match
- Switch frontend Dockerfile from yarn to npm ci + npm run build
- Add frontend/.dockerignore
Collaborator
Author
|
Hi, thanks for the thorough review! I've addressed all your comments in the latest commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR supersedes #58 and keeps the same core goal (local 3-tier preview), rebased onto current
mainand stabilized for merge.Contains original commits by @StefanSchubert plus integration/rebase/runtime/docs fixes by @xMinhx.
Why supersede #58
PR #58 currently points to an older head state and does not include the rebase-era fixes required to run reliably on current
main.Key changes
frontend/Dockerfile,frontend/nginx.conf).dev/prodDocker stages and use Gunicorn in prod with properLOG_LEVELexpansion.makemigrationsfrom backend entrypoint; keepmigrate.docker-compose.ci.ymlusestarget: prod).QUICK_START.md,PROJEKTÜBERSICHT_3TIER.md,README-DEV-INSTALLATION.md).backend/staticfiles/*).Validation
docker compose -f docker-compose-preview.yml up --build -dsucceeds./responds200./check_healthresponds200./api/projectsreturns401/403(expected)./static/rest_framework/css/default.cssreturns200.docker compose -f docker-compose.ci.yml build securecheckplus_serversucceeds.Migration policy rationale
makemigrationsis intentionally manual, whilemigrateremains automatic at startup.Reason:
Supersedes