fix(*): tighten generated transformer types (#668)#670
Conversation
Signed-off-by: Rishabh Jain <rishabhj2005@gmail.com>
|
Hi @mttrbrts, I opened a follow-up for #668 that tightens the JSDoc-driven generated types for the public transformer APIs you called out. This change stays intentionally narrow and focuses on:
What changed:
I also verified the touched packages with lint plus direct package test runs. One caveat I noted in the PR body: the current upstream |
|
Thanks for the contribution @Rishabh060105, unfortunately I already have an open PR which addresses this issue. Please review the PR, I'd love to understand if you found any more gaps that I missed? |
Closes #668
Tightens the JSDoc-driven generated TypeScript declarations for the public transformer APIs highlighted in #668 so downstream consumers get structured JSON and token-stream types instead of broad
anysignatures.Changes
CommonMarkTransformer,CiceroMarkTransformer,TemplateMarkTransformer, andHtmlTransformerto use structured JSON aliases, concrete token-stream shapes, and Concerto runtime helper types where appropriateany, and updated the transpiledTemplateMarkTransformerruntime artifact to keep the package outputs in syncFlags
anywith Concerto model types #668; it does not attempt a repo-wide cleanup of every remaining broad declarationtsctoolchain on this checkout is3.9.10, which still trips over modern dependency.d.tssyntax when running the standardbuild:types/npm testpath on upstreammainScreenshots or Video
Related Issues
anywith Concerto model types #668Author Checklist
--signoffoption of git commit.mainfromRishabh060105/issue-668-tighten-generated-typesValidation
npm run lint --workspace packages/markdown-commonnpm run lint --workspace packages/markdown-ciceronpm run lint --workspace packages/markdown-templatenpm run lint --workspace packages/markdown-html../../node_modules/.bin/jest --timeOut=10000 --silentinpackages/markdown-common../../node_modules/.bin/jest --timeOut=10000 --silentinpackages/markdown-cicero../../node_modules/.bin/mocha --timeout 30000inpackages/markdown-template../../node_modules/.bin/jest --timeOut=10000 --silentinpackages/markdown-html