[Arya-AV]

Closes #288

Changes

• Replaced deprecated ::set-output workflow syntax in scripts/tag.js with direct append writing to $GITHUB_OUTPUT.
• Maintained console fallback behavior when executing outside GitHub Actions (e.g., local runs).
• Ported the implementation established in ci: harden npm release workflow concerto#1324.

Flags

• None

Screenshots or Video

• N/A (utility script change verified via local node scripts/tag.js)

Related Issues

• Issue Release workflow: scripts/tag.js uses the deprecated ::set-output command #288
• Pull Request ci: harden npm release workflow concerto#1324

Author Checklist

• Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
• Vital features and changes captured in unit and/or integration tests
• Commits messages follow AP format
• Extend the documentation, if necessary
• Merging to main from Arya-AV:fix/deprecate-set-output-scripts-tag

[mira-accord-project]

Welcome to Accord Project, and thank you for the PR, @Arya-AV. The old ::set-output workflow command is deprecated by GitHub, so moving scripts/tag.js to GITHUB_OUTPUT is a worthwhile fix. Because it touches the release script, a maintainer will want to read it with care. We aim to give you feedback within a few working days.

Drafted by an Accord Project agent, reviewed by a maintainer.

[mira-accord-project]

Thank you for this fix, Arya-AV, and for linking the issue. Moving scripts/tag.js off the deprecated ::set-output command is the right change. It writes tag=--tag=<tag> to GITHUB_OUTPUT, so steps.tag.outputs.tag in publish.yml gets the same value as before. The local fallback prints --tag=<tag>, which is handy for trying it by hand. I found nothing blocking. There is one small style nit below. Once it is tidied and a maintainer has approved, this looks ready to merge.

Nothing blocking; some suggestions below. Findings: 1 nit.

---

_{Automated review by Mira, an Accord Project agent, at 6850c44. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.}

[mira-accord-project]

nit · conventions

const fs=require('fs'); is missing spaces around =, unlike the neighbouring const semver = require('semver');. The blank line after 'use strict'; was also removed. Please write const fs = require('fs'); and put the blank line back, so the file keeps a consistent style.

[Arya-AV]

Hi maintainers,

I've addressed the formatting feedback and added the required DCO sign-off. The DCO check is now passing.
The remaining workflows are awaiting approval. Could you please review the PR when convenient?

[mira-accord-project]

Thank you, Arya-AV, for moving scripts/tag.js off the deprecated ::set-output command, and for tidying the const fs = require('fs'); spacing. I checked the change against the Publish workflow. The tag step has id: tag, and the publish step reads steps.tag.outputs.tag as --tag=latest or --tag=unstable. Writing tag=--tag=<tag> to GITHUB_OUTPUT produces exactly that value. Printing --tag=<tag> when GITHUB_OUTPUT is unset is a sensible local fallback. I have no further findings. To merge, the main CI workflows need a maintainer to approve their first run, and a maintainer needs to review and approve. The earlier thread on the spacing is now fixed and can be resolved.

No problems found.

---

_{Automated review by Mira, an Accord Project agent, at 3235317. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.}