fix: replace StackPanel with Grid in TabControl Template to support internal ScrollViewer#87
Open
BevisQiu wants to merge 1 commit into
Open
fix: replace StackPanel with Grid in TabControl Template to support internal ScrollViewer#87BevisQiu wants to merge 1 commit into
BevisQiu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current ControlTemplate of TabControl, the content presenter is wrapped within a StackPanel. This causes an issue where a ScrollViewer placed inside a TabItem fails to function correctly because StackPanel provides infinite space to its children, preventing the ScrollViewer from calculating its viewport size.
This PR replaces the StackPanel with a Grid to ensure that content correctly fills the available space and allows ScrollViewer to trigger scrolling as expected.
I have tested the following XAML, and the ScrollViewer now scrolls correctly: