Any time we use pass a callsign over http we need to encodeURIComponent()#1096
Draft
alanhargreaves wants to merge 1 commit into
Draft
Any time we use pass a callsign over http we need to encodeURIComponent()#1096alanhargreaves wants to merge 1 commit into
alanhargreaves wants to merge 1 commit into
Conversation
Collaborator
Author
|
I'm running this locally to verify that it addresses the issue. If to this evening, I expect to see VK2IO/P activating in the morning on CW. |
Collaborator
Author
|
ok it looks like |
accius
reviewed
Jun 22, 2026
accius
left a comment
Owner
There was a problem hiding this comment.
Correct fix. Line 280 was the only callsign-bearing fetch in this file still interpolating raw, the user-callsign spots fetch at line 244 already runs through encodeURIComponent, so this brings the location lookup in line with it. A skimmer callsign with a / portable suffix would otherwise break the path segment.
One thing: this is still marked draft. Flip it to ready when you are happy with it and it can go in.
K0CJH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Any time we pass a callsign to the server API in
useRBN.jswe need to encode the callsign so callsigns with suffixes like/Pdon't screw things up.Type of change
How to test
Watch an RBN skimmer for a known CW op operating with a suffix like
/Pthat has also spotted in either DX Cluster or an ActivatorPanel type spot and verify that we get the proper location.Checklist
server.js: caches have TTLs and size caps (we serve 2,000+ concurrent users)var(--accent-cyan), etc.).bak,.old,console.logdebug lines, or test scripts included