Python package/pyodide index - #6
Open
abstractedfox wants to merge 13 commits into
Open
Conversation
abstractedfox
force-pushed
the
python-package/pyodide-index
branch
from
July 24, 2026 05:59
30a9599 to
819c561
Compare
ryanking13
reviewed
Jul 24, 2026
There was a problem hiding this comment.
I am not sure if this test is useful to have as an e2e. I think testing parseToml whether it handles empty/invalid toml files should be enough.
Owner
Author
There was a problem hiding this comment.
Just to not leave this hanging, this originally showed as a diff due to a mistake I made rebasing. This test was first written when createWorker wouldn't work at all with pyproject.toml, but it is pretty old now. Should I make a note to remove it in a future PR (or go back and do it in this one)?
There was a problem hiding this comment.
I think you can clean it up in this PR as you are adding other more useful e2e tests.
abstractedfox
force-pushed
the
python-package/pyodide-index
branch
from
July 27, 2026 20:35
819c561 to
3119e96
Compare
dom96
reviewed
Jul 28, 2026
abstractedfox
changed the base branch from
diffsview/python-package/pypi-simple-api
to
main
July 28, 2026 22:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local PR while waiting to be able to move on cloudflare agents cloudflare#1953 so individual changes can be reviewed in advance. Adds the pyodide index as an available package source, both in general and as the default package index (per advice from @ryanking13)
Uncertain about the changes to app.ts, I made those changes out of caution since the pattern looked relevant to what I was changing, but I don't actually know what this file is used for, so some additional feedback would be helpful there