Dont expose extract_probability as C API parameter#169
Open
RomanValov wants to merge 1 commit into
Open
Conversation
Owner
|
Good catch @RomanValov. You're right, extract_probability is handled entirely on the Python side, so having it inside PARAMS_SCHEMA is misleading and can definitely cause confusion given the current docs/behavior. I just ran CI, and it's currently failing. There also appear to be some merge conflicts since another PR was merged into main recently. Could you please rebase onto the latest main, resolve any conflicts, and fix the syntax error? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presence of
extract_probabilityparameter onPARAMS_SCHEMAdict causes a confusionbecause docs say
PARAMS_SCHEMAparameters should be recognized onModel.__init__and passed to underlying whisper.cpp library.
But attempts to pass
extract_probabilitytoModel.__init__cause segfaults.Indeed
extract_probabilityhandled purely on python side.CC @wooii