master update - #21
Merged
Merged
Conversation
… modal labels * fix(client_v2): prevent FiltersConfig from overwriting filter interval on mount The mount effect in FiltersConfig posted setFiltersConfig unconditionally, which could overwrite the backend interval (e.g. 1 hour) with the default 24 hours before getFilteringStatus resolved. Only post when the enabled toggle actually changes. * fix(client_v2): translate filter update modal radio labels reactively The radio options were built once at module load, freezing labels in English after a language switch. Rebuild them in a memo so intl resolves per current locale. --------- Co-authored-by: Hoang Rio <hi@hoangnguyendong.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a PR please make sure that:
You have discussed your solution in an issue and have got an
approval from a maintainer. See our
contribution guide.
This isn't a localization fix; please send those to our
CrowdIn
page.
Your code follows our
code guidelines.
Add a short description here. The description should include:
Which issue this PR closes (
Closes #NNNN.) or updates (Updates #NNNN.). Please do not open PRs without filing an issue first.A short description of how the change achieves that.
Do not forget to remove these instructions!