Repository navigation
pubsub: raise 90011 when releasing a realtime channel that isn't detached - #729
Open
SimonWoolf wants to merge 1 commit into
Open
SimonWoolf wants to merge 1 commit into
SimonWoolf wants to merge 1 commit into
Conversation
…ched Specification 6.3.0 replaces RTS4a with RTS4c-e. Channels.release used to remove a channel whatever its state, so an attached channel was dropped from the collection while still attached in the Ably service. It now raises an AblyException with code 90011 and status 400 for a channel that is not INITIALIZED, DETACHED or FAILED, and leaves the channel as it was (RTS4e); it still returns quietly for an unknown name (RTS4c) and removes a channel in one of those states (RTS4d). This is a breaking change: callers must await channel.detach() before releasing. 3.x logs a deprecation warning in this case (RTS4b). The channels collection UTS tests are rederived for RTS4c-e, which closes the RTS4a release deviation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RTS4c–e from specification 6.3.0 (ably/specification#557).
Breaking change:
channels.release(name)on a realtime client now raises anAblyExceptionwith code 90011 and status code 400 if the channel isn'tINITIALIZED,DETACHEDorFAILED, and leaves the channel attached and in the collection. Previously it removed the channel whatever its state, which could leave it attached in the Ably service. Releasing a name that isn't in the collection is still a no-op. Releasing a channel in one of those three states still removes it.release()stays synchronous.Migration: detach the channel and wait for the detach to complete before releasing it:
UPDATING.mddocuments this.deviations.md.90011 is registered in ably/ably-common#367. 3.x logs a deprecation warning for this case (#728). Reference ably-js PRs: ably/ably-pubsub-js#2322 (deprecation) and ably/ably-pubsub-js#2323 (next major).
🤖 Generated with Claude Code