Skip to content

Fix authMethod default not stored in auth options (AO2) #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpruijsen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix authMethod default not stored in auth options (AO2) #2313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/common/lib/client/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,11 @@ class Auth {
this._userSetClientId(authOptions.clientId);
}

/* AO2: authMethod defaults to GET and is stored on the options object */
if (!('authMethod' in authOptions)) {
authOptions.authMethod = 'GET';
}

this.authOptions = authOptions;
}
}
Expand Down
12 changes: 0 additions & 12 deletions test/uts/deviations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,18 +110,6 @@ These tests assert spec behavior but are skipped by default because they are kno

---

### options_types: AO2 - authMethod default not stored

**Spec (AO2)**: `authMethod` should default to `'GET'` and be stored in auth options.

**ably-js behavior**: Default `authMethod` is not stored.

**Test**: `AO2 - authMethod defaults to GET`.

**Issue**: [#2205](https://github.com/ably/ably-js/issues/2205)

---

### channels: RTL4c - errorReason not cleared on successful re-attach

**Spec (RTL4c, proposed)**: When a confirmation ATTACHED is received, the channel's errorReason should be set to null.
Expand Down
2 changes: 0 additions & 2 deletions test/uts/rest/unit/types/options_types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,6 @@ describe('uts/rest/unit/types/options_types', function () {
*/
// UTS: rest/unit/AO2/auth-options-attributes-0.1
it('AO2 - authMethod defaults to GET', function () {
// DEVIATION: see deviations.md
if (!process.env.RUN_DEVIATIONS) this.skip();
installMockHttp(simpleMock());
const client = new Ably.Rest({
authUrl: 'https://auth.example.com/token',
Expand Down
Loading