Repository navigation
Address the review feedback on the UTS split - #2290
Conversation
The "Where CI runs them" section said there was no UTS-specific CI job and that the suite ran as part of the full test suite, while naming uts.yaml in the same sentence. It now describes the workflow: six legs running the UTS target, with integration-test.yaml skipping it.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe PR removes trailing whitespace from the UTS workflow and updates contributor and UTS README documentation to describe the dedicated UTS CI workflow and its coverage. ChangesUTS CI alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The documented workflow and remaining TODO describe different CI capabilities; no actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit tidies trailing space, Comment |
Two blank lines in the job comment carried trailing spaces. EditorConfig scopes trimming to Swift and Objective-C files, so nothing in CI catches it.
The workflow section said the two workflows cover the test plan exactly once, which holds for target ownership but not for execution: the UTS target runs twice per platform, once per UTS_SIDE value.
9f681d6 to
4eaf493
Compare
Stacked on #2275, and addresses the review feedback on it.
Three commits, one per finding.
ProxySession's usage example bypassed the seam (r4026592486). The doc comment atTest/UTS/infra/integration/proxy/ProxySession.swift:149showedARTRealtime(options: options), so a reader copying it got a client that runs core-side whateverUTS_SIDEsays. It now builds throughmakeRealtimeForSide(options:), like every other realtime client in the suite.Trailing whitespace in
uts.yaml(r4026524234). Two blank lines in the job comment carried trailing spaces..editorconfigscopes trimming to*.{swift,m,h}, so nothing in CI catches it.Test/UTS/README.md's CI section described a state that no longer held (r3987939748). It said there was no UTS-specific CI job and that the suite ran as part of the full test suite, while naminguts.yamlin the same sentence. The section now describes the workflow: the lanes passsuite:uts, which fastlane turns into-only-testing:UTS; six legs run iOS, tvOS and macOS twice each, once perUTS_SIDEvalue; andintegration-test.yamlpassessuite:sdk, which skips this target.Not addressed here, because neither needs a code change:
Test/UTS/deviations.mdis still untouched by any split work.Summary by CodeRabbit
UTS_SIDEvalues.