Skip to content

PROBE (do not merge): does UTS_SIDE reach the test process on simulators? - #2271

Closed
maratal wants to merge 1 commit into
split/uts-per-sidefrom
probe/uts-side-delivery
Closed

maratal wants to merge 1 commit into
split/uts-per-sidefrom
probe/uts-side-delivery

Conversation

@maratal

@maratal maratal commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Throwaway, to be closed as soon as it has answered its question.

Sets Test/UTSDevice.xctestplan's configuration value to bogus and restricts the run to SideSeamTests.

Side.swift aborts on an unrecognised UTS_SIDE, so the two outcomes are unambiguous:

  • device legs crash with Fatal error: UTS_SIDE must be 'core' or 'device', got 'bogus' — the plan delivers the variable on that platform.
  • device legs pass — the variable never arrived, the leg silently ran as core, and the device coverage on that platform is illusory.

The core legs are the control and should pass either way.

This is the only way to tell, because a device leg that receives nothing runs as core and passes exactly like one that works.

Temporary. Sets the device plan's value to an invalid one, so a leg that
receives it aborts on Side.swift's fatalError and one that does not passes
as core. Restricted to SideSeamTests to keep it off the sandbox.

Revert before merge.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maratal

maratal commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Answered: the plan does deliver UTS_SIDE on simulators.

Leg Result
iOS … device, UTSDevice failed with Fatal error: UTS_SIDE must be 'core' or 'device', got 'bogus'
tvOS … device, UTSDevice same
macOS … device, UTSDevice cancelled by fail-fast; already proven locally
all three core, Ably passed, as the control

So the device legs on #2268 are running genuine device-mode coverage on all three platforms.

This probe was the only way to establish that: a device leg that receives nothing runs as core and passes exactly like one that works, so a green leg proves nothing. That is the same trap that made TEST_RUNNER_ appear to work.

Closing; nothing here is meant to merge.

This branch was successfully deployed

4 active deployments
staging/pull/2271/markdown-api-reference — bd1bac4f Deployed Sep 8, 2026 by github-actions[bot]
staging/pull/2271/jazzydoc — bd1bac4f Deployed Sep 8, 2026 by github-actions[bot]
staging/pull/2271/AblyLiveObjects — bd1bac4f Deployed Sep 8, 2026 by github-actions[bot]
staging/pull/2271/features — bd1bac4f Deployed Sep 8, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant