Repository navigation
Conversation
Temporary. Sets the device plan's value to an invalid one, so a leg that receives it aborts on Side.swift's fatalError and one that does not passes as core. Restricted to SideSeamTests to keep it off the sandbox. Revert before merge.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Answered: the plan does deliver
So the device legs on #2268 are running genuine device-mode coverage on all three platforms. This probe was the only way to establish that: a device leg that receives nothing runs as Closing; nothing here is meant to merge. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway, to be closed as soon as it has answered its question.
Sets
Test/UTSDevice.xctestplan's configuration value tobogusand restricts the run toSideSeamTests.Side.swiftaborts on an unrecognisedUTS_SIDE, so the two outcomes are unambiguous:Fatal error: UTS_SIDE must be 'core' or 'device', got 'bogus'— the plan delivers the variable on that platform.core, and the device coverage on that platform is illusory.The
corelegs are the control and should pass either way.This is the only way to tell, because a device leg that receives nothing runs as
coreand passes exactly like one that works.