Skip to content

fix(curriculum): add actionable JSON assertion messages - #141

Open
frobel0520 wants to merge 1 commit into
abhiksark:devfrom
frobel0520:fix/issue-101-json-assertions
Open

fix(curriculum): add actionable JSON assertion messages#141
frobel0520 wants to merge 1 commit into
abhiksark:devfrom
frobel0520:fix/issue-101-json-assertions

Conversation

@frobel0520

Copy link
Copy Markdown

Summary

  • Add actionable, beginner-facing assertion messages to the seven bare checks in checks/json/json1.py through json6.py.
  • Preserve every assertion predicate, execution order, helper statement, and success output.
  • Keep the change limited to the six files listed in curriculum: add actionable assertion messages to JSON checks (batch 1 of 2) #101; no learner exercises, reference solutions, hints, documentation, or curriculum metadata changed.

Closes #101

Tests

  • python -m pytest tests/integration/test_solution_verify.py -q — 1 passed
  • python -m pytest -q — 209 passed, 6 failed
    • The six failures are Windows symlink-permission tests (WinError 1314) in doctor/manifest coverage; they are unrelated to this change.
  • python -m pythonlings --root tests/fixtures/passing_curriculum verify — passed (passing1, passing2)
  • AST audit of the six listed files — 0 bare assertions remaining

Screenshots

Not applicable; this is a curriculum check-message change with no TUI changes.

Checklist

  • Updated docs when behavior changed — not applicable; curriculum: add actionable assertion messages to JSON checks (batch 1 of 2) #101 explicitly limits this change to assertion messages.
  • Added or updated tests — not applicable; existing verification tests cover the unchanged predicates.
  • Verified python -m pytest -q — completed; 209 passed and 6 unrelated Windows symlink-permission tests failed with WinError 1314.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 44c0023d-9c04-43b7-a5cf-ef84b17d518c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant