Phase 1A: profile core and primary education - #3
Merged
Conversation
Refine the profile and education schema with explicit column grants, RLS, section revision triggers, review and primary-selection RPCs, and forward-only legacy compatibility.
Exercise refined profile permissions, education CRUD, constrained primary and review RPCs, review freshness, and cross-user denial through real local Auth and PostgREST.
Install React Router 8.3.0 and introduce authenticated redirects, a protected profile layout, bookmarkable profile routes, safe route errors, and in-memory router coverage.
Add typed profile, education, and review repositories with protected basic-profile and education CRUD workflows, explicit primary selection, validation, review controls, and safe user feedback.
Add a pure versioned education-slice completeness evaluator with public-safe tests and document its named checks, neutral deferred availability state, and migration decisions.
Make migrated confirmation timestamps nullable, add an automated Phase 0-to-Phase 1A compatibility path, and pin React Router exactly.
Use the completeness evaluator as the overview source, distinguish missing review state, refresh visible review status, protect zero-row saves, validate education inputs, and gate edit forms on loaded records.
Add browser root-profile deletion and direct review-write integration coverage, and reconcile the documented API security checks.
Add explicit basic-profile loading, ready, missing, and error states; refresh education review state; guard duplicate mutations; and cover observable page workflows.
Cover privileged function hardening, primary and review behavior, API concurrency and isolation, and stronger legacy migration assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Independent review corrections
last_confirmed_atis nullable for migrated Phase 0 rows, while new manual rows retain thenow()default. Empty-data resets missed this because no legacy rows existed to update to NULL../supabase/scripts/migration-compatibility-test.sh: reset through Phase 0, insert synthetic Phase 0 fixtures, apply pending Phase 1A migration, and assert safe preservation/backfill/provenance/revision behavior. CI runs it before its normal fresh reset.react-routerexactly to8.3.0and verified the installed version.Final review corrections
Verification
Exclusions
No deferred Phase 1A sections, resume/ingestion/opportunity features, hosted resources, deployment work, or real profile data.