Skip to content

Give every example the navigated branch, and drop the exemption - #146

Merged
oblomov-dev merged 1 commit into
mainfrom
claude/examples-navigated
Aug 16, 2026
Merged

Give every example the navigated branch, and drop the exemption#146
oblomov-dev merged 1 commit into
mainfrom
claude/examples-navigated

Conversation

@oblomov-dev

Copy link
Copy Markdown
Member

The 24 examples on 12 pages that dispatched on check_on_init( ) alone now cover check_on_navigated( ) too, and the hint exemption in check-examples.mjs is gone — the rule runs at its own severity again and reports nothing.

This closes the last place missing-on-navigated-branch was still open. The three sample repositories reached zero earlier today; the documentation was the leftover, and the one that mattered most: a sample gets read, an example gets copied.

The fix is one line, not the restructure the exemption predicted

That note said each example needed a view_display( ) method extracted and called from both branches — which is what I assumed the sample repositories would do. They did not. R-6 landed there as:

IF client->check_on_init( ) OR client->check_on_navigated( ).

and it is plainly better: no extracted method, no protected client attribute, no second dispatch branch. The teaching shape of every example survives untouched, and hello_world.md grows by 34 characters instead of by a method. Copying what the corpus actually does also keeps the documentation and the 530 sample apps showing one pattern rather than two.

How it was applied

Inside ABAP fences only, and only where the block did not already mention check_on_navigated — so an example that already handles the branch separately was left alone. 42 fenced blocks in 25 files, more than the 24 the linter counted, because it only judges blocks that build a view.

One did not match the pattern and was done by hand: technical/concept.md gates on check_on_init( ) OR partly = abap_false, where the navigated check joins the existing OR chain.

Verified

before 24 problems (0 errors, 0 warnings, 24 hints)
after the edit, still at hint 1 problem → found concept.md
after the hand fix Success! No findings detected.
exemption removed, rule at warning 46 files, 0 failing

npm run check (version + build + examples + sample links) is green.


Generated by Claude Code

The 24 examples on 12 pages that dispatched on check_on_init( ) alone now
cover check_on_navigated( ) too, and the `hint` exemption in
check-examples.mjs is gone: the rule runs at its own severity again and
reports nothing.

The fix is one line per example, not the restructure the exemption
predicted. That note said each example needed a view_display( ) method
extracted and called from both branches - which is what I assumed the
sample repositories would do. They did not. R-6 landed there as

    IF client->check_on_init( ) OR client->check_on_navigated( ).

and it is plainly better: no extracted method, no protected client
attribute, no second dispatch branch. The teaching shape of every example
survives untouched, and hello_world.md grows by 34 characters instead of a
method. Copying what the corpus actually does also keeps the documentation
and the 530 sample apps showing one pattern rather than two.

Applied inside ABAP fences only, and only where the block did not already
mention check_on_navigated, so an example that already handles the branch
separately was left alone. 42 fenced blocks in 25 files - more than the 24
the linter counted, because it only judges blocks that build a view.

One did not match the pattern and was done by hand: technical/concept.md
gates on `check_on_init( ) OR partly = abap_false`, where the navigated
check joins the existing OR chain.
Copilot AI lite review requested due to automatic review settings August 16, 2026 15:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@oblomov-dev
oblomov-dev merged commit a46479b into main Aug 16, 2026
1 check passed
@oblomov-dev
oblomov-dev deleted the claude/examples-navigated branch August 16, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants