Give every example the navigated branch, and drop the exemption - #146
Merged
Conversation
The 24 examples on 12 pages that dispatched on check_on_init( ) alone now
cover check_on_navigated( ) too, and the `hint` exemption in
check-examples.mjs is gone: the rule runs at its own severity again and
reports nothing.
The fix is one line per example, not the restructure the exemption
predicted. That note said each example needed a view_display( ) method
extracted and called from both branches - which is what I assumed the
sample repositories would do. They did not. R-6 landed there as
IF client->check_on_init( ) OR client->check_on_navigated( ).
and it is plainly better: no extracted method, no protected client
attribute, no second dispatch branch. The teaching shape of every example
survives untouched, and hello_world.md grows by 34 characters instead of a
method. Copying what the corpus actually does also keeps the documentation
and the 530 sample apps showing one pattern rather than two.
Applied inside ABAP fences only, and only where the block did not already
mention check_on_navigated, so an example that already handles the branch
separately was left alone. 42 fenced blocks in 25 files - more than the 24
the linter counted, because it only judges blocks that build a view.
One did not match the pattern and was done by hand: technical/concept.md
gates on `check_on_init( ) OR partly = abap_false`, where the navigated
check joins the existing OR chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 24 examples on 12 pages that dispatched on
check_on_init( )alone now covercheck_on_navigated( )too, and thehintexemption incheck-examples.mjsis gone — the rule runs at its own severity again and reports nothing.This closes the last place
missing-on-navigated-branchwas still open. The three sample repositories reached zero earlier today; the documentation was the leftover, and the one that mattered most: a sample gets read, an example gets copied.The fix is one line, not the restructure the exemption predicted
That note said each example needed a
view_display( )method extracted and called from both branches — which is what I assumed the sample repositories would do. They did not. R-6 landed there as:and it is plainly better: no extracted method, no protected
clientattribute, no second dispatch branch. The teaching shape of every example survives untouched, andhello_world.mdgrows by 34 characters instead of by a method. Copying what the corpus actually does also keeps the documentation and the 530 sample apps showing one pattern rather than two.How it was applied
Inside ABAP fences only, and only where the block did not already mention
check_on_navigated— so an example that already handles the branch separately was left alone. 42 fenced blocks in 25 files, more than the 24 the linter counted, because it only judges blocks that build a view.One did not match the pattern and was done by hand:
technical/concept.mdgates oncheck_on_init( ) OR partly = abap_false, where the navigated check joins the existing OR chain.Verified
24 problems (0 errors, 0 warnings, 24 hints)hint1 problem→ foundconcept.mdSuccess! No findings detected.warning46 files, 0 failingnpm run check(version + build + examples + sample links) is green.Generated by Claude Code