Repository navigation
Conversation
…EM#447, #448) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…quation forms Re-executed against abTEM dev 08ee6e8c. The structure-matrix dropdown described the old, inconsistent metric; it now gives the default use_wave_eq='exact' form and the paraxial and standard ones. The weak [-21 1 -1] Bloch-wave/multislice mismatch was the metric bug, not convergence, and is gone. The Ewald-sphere excitation error is not a parabola approximation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Re-executed against abTEM dev b634b93a. The walkthrough no longer says every BlochWaves method takes an energy ensemble: the structure and scattering matrices need a single energy (select_energy). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog entries for abTEM#447, abTEM#448 and abTEM#521. All three are merged into
dev(6ec0bed7, 08ee6e8c and 98bbae60), so this is ready to merge.Changes
docs/abtem/changelog.md(Upcoming 1.1.0):Features, under energy ensembles (#257): Bloch-wave rotation ensembles accept a list of energies (#521). Results get an
EnergyAxisafter the rotation axes, the axis order of a multislice rotation series, and each energy and orientation keeps its own beams.Features:
BlochWavesnow defaults touse_wave_eq="exact", the non-paraxial counterpart ofFourierMultislice(order="exact"). The entry calls out that results computed with default arguments change, with the sizes measured in #448: below 1 % R at 100–300 keV, but up to 24 % at 20 keV off zone axis. It also covers:calculate_scattering_matrix(lazy=True)option and the GPU fixBugfixes: the inconsistent Bloch-wave metric:
use_wave_eq=Falsenow solves the textbook equation exactly, which moves it away from the full Helmholtz equation. The entry explains why, so the change is not mistaken for a regression in accuracy.tutorials/blochwave.ipynb, re-executed against abTEMdev08ee6e8c (≈ 59 min on CPU, no errors, no new warnings):use_wave_eq="exact"form (no metric), the paraxialTrueform, and the standardFalseform withexamples/notebooks/blochwave_quickstart.ipynb(and its thumbnail), re-executed against abTEMdevb634b93a (≈ 8 min, no errors). The printed outputs are unchanged at the displayed precision. The kinematical panel changes slightly, because its excitation-error weighting now follows the default form. The thumbnail is pixel-identical. The text needed no changes.walkthrough/wave_functions.ipynb, re-executed against the samedev. It mentionsBlochWavesonly in its text, so its output changes come from otherdevchanges: a renamed dask task in two array reprs, and plot layout. One sentence said everyBlochWavesmethod accepts an energy ensemble.calculate_structure_matrixandcalculate_scattering_matrixrequire a single energy (since abTEM#456), so it now says so and points toselect_energy.scripts/check_notebook_widgets.pypasses for all three notebooks.🤖 Posted by Claude Code on behalf of Toma