Repository navigation
Persist completed plan steps and exit execution - #3
Merged
Merged
Conversation
Execution only updated the extension's in-memory checklist, leaving the submitted plan's Markdown checkboxes unchecked. Persist current completion state after revdiff_mark_done and [DONE:n] markers, preserving all other plan text. The final completed step now runs the existing completion notification and idle transition immediately. This removes the execution-only tools and restores the saved tool list instead of waiting for a later agent_end event. Allow /revdiff-plan-mode to exit a nonempty, fully completed checklist. Keep the explicit /revdiff-plan-abort requirement for incomplete plans and plans without checklists, where completion cannot be inferred.
a4180p
force-pushed
the
persist-execution-progress
branch
from
September 8, 2026 16:11
a8a1023 to
432d817
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During execution,
revdiff_mark_doneand[DONE:n]markers changed only the extension's in-memory checklist. The status widget moved, but the submitted plan file retained[ ]checkboxes.Completion was checked only from
agent_end. That made finishing timing-dependent, and/revdiff-plan-moderejected every executing state even after every item had been completed.Changes
renderChecklist, which updates only checklist markers in the submitted Markdown while preserving indentation, bullet text, and non-checklist content.revdiff_mark_doneand recognized[DONE:n]markers.isChecklistComplete, which requires a nonempty checklist and every item completed.Plan Complete!message exactly once, restore prior tools, and return to idle./revdiff-plan-modeto exit a completed nonempty execution. Incomplete and checklist-free executions still require/revdiff-plan-abort.agent_endas a fallback for restored state / an already-complete plan.Tests
npm run validateafterrm -rf dist: 13/13 passing.New regression coverage verifies checkbox rendering preserves surrounding Markdown and that automatic completion requires a nonempty, fully completed checklist.