Skip to content

docs: AgentExecutor interface documentation#976

Merged
bartek-w merged 1 commit into1.0-devfrom
bartekw-auth
Apr 17, 2026
Merged

docs: AgentExecutor interface documentation#976
bartek-w merged 1 commit into1.0-devfrom
bartekw-auth

Conversation

@bartek-w
Copy link
Copy Markdown
Collaborator

Fixes #869 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces TODOs in agent_executor.py with comprehensive documentation regarding the request lifecycle, concurrency, exception handling, and cancellation workflows. It also introduces a new integration test for the 'Auth Required' scenario. Feedback includes addressing a potential AttributeError in the new test when handling non-streaming responses, correcting a redundant method call in the documentation, and improving the phrasing of the framework's response behavior description.

Comment thread tests/integration/test_scenarios.py Outdated
Comment thread src/a2a/server/agent_execution/agent_executor.py Outdated
Comment thread src/a2a/server/agent_execution/agent_executor.py Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

🧪 Code Coverage (vs 1.0-dev)

⬇️ Download Full Report

No coverage changes.

Generated by coverage-comment.yml

@bartek-w bartek-w changed the title AgentExecutor interface documentation doc: AgentExecutor interface documentation Apr 16, 2026
@bartek-w bartek-w changed the title doc: AgentExecutor interface documentation docs: AgentExecutor interface documentation Apr 16, 2026
@bartek-w bartek-w requested a review from ishymko April 16, 2026 10:57
@bartek-w bartek-w marked this pull request as ready for review April 16, 2026 10:57
@bartek-w bartek-w requested a review from a team as a code owner April 16, 2026 10:57
Comment thread src/a2a/server/agent_execution/agent_executor.py Outdated
@bartek-w bartek-w merged commit d667e4f into 1.0-dev Apr 17, 2026
18 checks passed
@bartek-w bartek-w deleted the bartekw-auth branch April 17, 2026 06:14
ishymko pushed a commit that referenced this pull request Apr 17, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.0.0-alpha.2](v1.0.0-alpha.1...v1.0.0-alpha.2)
(2026-04-17)


### ⚠ BREAKING CHANGES

* clean helpers and utils folders structure
([#983](#983))
* Raise errors on invalid AgentExecutor behavior.
([#979](#979))
* extract developer helpers in helpers folder
([#978](#978))

### Features

* Raise errors on invalid AgentExecutor behavior.
([#979](#979))
([f4a0bcd](f4a0bcd))
* **utils:** add `display_agent_card()` utility for human-readable
AgentCard inspection
([#972](#972))
([3468180](3468180))


### Bug Fixes

* Don't generate empty metadata change events in VertexTaskStore
([#974](#974))
([b58b03e](b58b03e)),
closes [#802](#802)
* **extensions:** support both header names and remove "activation"
concept ([#984](#984))
([b8df210](b8df210))


### Documentation

* AgentExecutor interface documentation
([#976](#976))
([d667e4f](d667e4f))
* move `ai_learnings.md` to local-only and update `GEMINI.md`
([#982](#982))
([f6610fa](f6610fa))


### Code Refactoring

* clean helpers and utils folders structure
([#983](#983))
([c87e87c](c87e87c))
* extract developer helpers in helpers folder
([#978](#978))
([5f3ea29](5f3ea29))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants