Skip to content

fix: wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guglielmo-san merged 5 commits into from
Apr 3, 2026
+76 −12
Merged

fix: wrong method name for ExtendedAgentCard endpoint in JsonRpc compat version #931

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c8cc7f
fix jsonrpc method name
guglielmo-san Apr 3, 2026
4680288
test
guglielmo-san Apr 3, 2026
085980f
remove test
guglielmo-san Apr 3, 2026
b6247b6
add tests
guglielmo-san Apr 3, 2026
d647d23
fix tests
guglielmo-san Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/a2a/compat/v0_3/jsonrpc_adapter.py
View file
Open in desktop
Comment thread
guglielmo-san marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class JSONRPC03Adapter:
'tasks/pushNotificationConfig/list': types_v03.ListTaskPushNotificationConfigRequest,
'tasks/pushNotificationConfig/delete': types_v03.DeleteTaskPushNotificationConfigRequest,
'tasks/resubscribe': types_v03.TaskResubscriptionRequest,
'agent/authenticatedExtendedCard': types_v03.GetAuthenticatedExtendedCardRequest,
'agent/getAuthenticatedExtendedCard': types_v03.GetAuthenticatedExtendedCardRequest,
}

def __init__( # noqa: PLR0913
Expand Down Expand Up @@ -225,7 +225,7 @@ async def _process_non_streaming_request(
id=request_id, result=None
)
)
elif method == 'agent/authenticatedExtendedCard':
elif method == 'agent/getAuthenticatedExtendedCard':
res_card = await self.get_authenticated_extended_card(
request_obj, context
)
Expand All @@ -248,7 +248,7 @@ async def get_authenticated_extended_card(
request: types_v03.GetAuthenticatedExtendedCardRequest,
context: ServerCallContext,
) -> types_v03.AgentCard:
"""Handles the 'agent/authenticatedExtendedCard' JSON-RPC method."""
"""Handles the 'agent/getAuthenticatedExtendedCard' JSON-RPC method."""
if not self.agent_card.capabilities.extended_agent_card:
raise ExtendedAgentCardNotConfiguredError(
message='Authenticated card not supported'
Expand Down
2 changes: 1 addition & 1 deletion src/a2a/compat/v0_3/jsonrpc_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ async def get_extended_agent_card(
return card

rpc_request = JSONRPC20Request(
method='agent/authenticatedExtendedCard',
method='agent/getAuthenticatedExtendedCard',
params={},
_id=str(uuid4()),
)
Expand Down
Loading