Conversation
Do not merge.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a test.txt file to the root directory. Feedback indicates that this violates the project's directory structure guidelines, which restrict files to the /src, /tests, and /docs directories, and suggests moving the file to the appropriate location.
| @@ -0,0 +1 @@ | |||
| Test | |||
Contributor
There was a problem hiding this comment.
The addition of 'test.txt' at the repository root appears to be a mistake or placeholder, as it does not address the 'spelling issue' mentioned in the PR title and deviates from the project's directory structure. If this was intended as a test case, it should be placed in the '/tests' directory following the established naming conventions.
References
- The repository style guide (Line 13) defines the key directories as /src, /tests, and /docs. Adding arbitrary files to the root directory is not aligned with this organizational structure. (link)
🧪 Code Coverage (vs
|
ishymko
added a commit
that referenced
this pull request
Apr 2, 2026
There is [code in spelling check](https://github.com/check-spelling/check-spelling/blob/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/unknown-words.sh#L182) which probes branch renaming to make sure that pipeline is set up according to the [guide](https://docs.check-spelling.dev/Feature:-Restricted-Permissions). It doesn't specify request body and looks for a specific message in the response assuming that token check happens before body validation. Seems like GitHub change behavior and body schema is validated before permissions, so such request fails with a different error now: ``` curl -s -X POST \ -H "Accept: application/vnd.github+json" \ -H "Authorization: Bearer $GITHUB_TOKEN" \ "https://api.github.com/repos/a2aproject/a2a-python/branches/1.0-dev/rename" { "message": "Invalid request.\n\nFor 'links/0/schema', nil is not an object.", "documentation_url": "https://docs.github.com/rest/branches/branches#rename-a-branch", "status": "422" } ``` Providing body gives a proper error: ```json { "message": "Resource not accessible by personal access token", "documentation_url": "https://docs.github.com/rest/branches/branches#rename-a-branch", "status": "403" } ``` Trying to update the workflow according to the sample https://raw.githubusercontent.com/check-spelling/spell-check-this/main/.github/workflows/spelling.yml.
ishymko
added a commit
that referenced
this pull request
Apr 2, 2026
There is [code in spelling check](https://github.com/check-spelling/check-spelling/blob/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/unknown-words.sh#L182) which probes branch renaming to make sure that pipeline is set up according to the [guide](https://docs.check-spelling.dev/Feature:-Restricted-Permissions). It doesn't specify request body and looks for a specific message in the response assuming that token check happens before body validation. Seems like GitHub change behavior and body schema is validated before permissions, so such request fails with a different error now: ``` curl -s -X POST \ -H "Accept: application/vnd.github+json" \ -H "Authorization: Bearer $GITHUB_TOKEN" \ "https://api.github.com/repos/a2aproject/a2a-python/branches/1.0-dev/rename" { "message": "Invalid request.\n\nFor 'links/0/schema', nil is not an object.", "documentation_url": "https://docs.github.com/rest/branches/branches#rename-a-branch", "status": "422" } ``` Providing body gives a proper error: ```json { "message": "Resource not accessible by personal access token", "documentation_url": "https://docs.github.com/rest/branches/branches#rename-a-branch", "status": "403" } ``` Trying to update the workflow according to the sample https://raw.githubusercontent.com/check-spelling/spell-check-this/main/.github/workflows/spelling.yml.
ishymko
added a commit
that referenced
this pull request
Apr 2, 2026
See #922, `pull_request_target` apparently requires pushing to `main`.
Member
Author
|
Didn't help, reported in check-spelling/check-spelling#103. |
ishymko
added a commit
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is code in spelling check which probes branch renaming to make sure that pipeline is set up according to the guide.
It doesn't specify request body and looks for a specific message in the response assuming that token check happens before body validation. Seems like GitHub change behavior and body schema is validated before permissions, so such request fails with a different error now:
Providing body gives a proper error:
{ "message": "Resource not accessible by personal access token", "documentation_url": "https://docs.github.com/rest/branches/branches#rename-a-branch", "status": "403" }Trying to update the workflow according to the sample https://raw.githubusercontent.com/check-spelling/spell-check-this/main/.github/workflows/spelling.yml.