chore: remove the use of deprecated types from VertexTaskStore (#889)#891
Conversation
…oject#889) * vertexai.Part & co. will be replaced soon by genai.Part & co. * It's better to use the more specifically named variants of `Task` and `Status`: `A2aTask` and `A2aTaskStatus`. For a2aproject#751
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Vertex task converter to use more specific and modern types from the vertexai and google.genai libraries. The deprecated vertexai.Part is replaced with genai.Part, and the generic vertexai.State is replaced with the more specific vertexai.A2aTaskState. These changes are applied consistently across the converter and its tests. A defensive check for None has also been added when processing inline data, which improves robustness. The changes are correct and improve the code's clarity and maintainability.
🧪 Code Coverage (vs
|
vertexai.Part& co. will be replaced soon bygenai.Part& co.TaskandStatus:A2aTaskandA2aTaskStatus.For #802