chore: Combine python configurations into pyproject.toml#491
chore: Combine python configurations into pyproject.toml#491holtskinner merged 2 commits intomainfrom
pyproject.toml#491Conversation
Summary of ChangesHello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly streamlines the project's Python development environment by migrating all tool-specific configurations into a single, central Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great step towards modernizing the project's configuration by consolidating settings into pyproject.toml. The migration of .coveragerc, .mypy.ini, and .ruff.toml is mostly correct. I've found a critical issue with a duplicated table in the Ruff configuration that would break the TOML parsing, and a minor omission of a rule from the ignore list. Once these are addressed, this will be a solid improvement.
No description provided.