Skip to content

chore: Combine python configurations into pyproject.toml#491

Merged
holtskinner merged 2 commits intomainfrom
cleanup-pyproject
Oct 7, 2025
Merged

chore: Combine python configurations into pyproject.toml#491
holtskinner merged 2 commits intomainfrom
cleanup-pyproject

Conversation

@holtskinner
Copy link
Copy Markdown
Member

No description provided.

@holtskinner holtskinner requested a review from a team as a code owner October 7, 2025 15:34
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly streamlines the project's Python development environment by migrating all tool-specific configurations into a single, central pyproject.toml file. This consolidation simplifies project setup, improves maintainability, and provides a unified source of truth for how various Python tools should behave within the project.

Highlights

  • Centralized Configuration: All Python tool configurations for coverage, mypy, and ruff have been consolidated into the pyproject.toml file, reducing the number of separate configuration files.
  • File Removal: The individual configuration files .coveragerc, .mypy.ini, and .ruff.toml have been removed from the repository.
  • pyproject.toml Enhancements: The pyproject.toml file now includes comprehensive settings for coverage, mypy, and ruff, mirroring the configurations previously held in their dedicated files. Additionally, build system configurations for hatchling and uv-dynamic-versioning were adjusted, and an exclusion for tests/ was added to the sdist target.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great step towards modernizing the project's configuration by consolidating settings into pyproject.toml. The migration of .coveragerc, .mypy.ini, and .ruff.toml is mostly correct. I've found a critical issue with a duplicated table in the Ruff configuration that would break the TOML parsing, and a minor omission of a rule from the ignore list. Once these are addressed, this will be a solid improvement.

Comment thread pyproject.toml
Comment thread pyproject.toml
@holtskinner holtskinner merged commit 63a8a18 into main Oct 7, 2025
9 checks passed
@holtskinner holtskinner deleted the cleanup-pyproject branch October 7, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant