chore(deps): Create all extra to simplify installation and testing#468
chore(deps): Create all extra to simplify installation and testing#468holtskinner merged 4 commits intomainfrom
all extra to simplify installation and testing#468Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the installation process for the a2a-sdk by consolidating all optional dependencies into a single, convenient "all" extra. This change simplifies dependency management for developers and users, making it easier to get started with the full feature set of the SDK.
Highlights
- Simplified Dependency Installation: A new "all" extra has been introduced, allowing users to install all optional dependencies of the a2a-sdk (including http-server, sql, encryption, grpc, and telemetry) with a single command like "pip install a2a-sdk[all]".
- Documentation Update: The README.md has been updated to reflect the new "all" extra and its installation instructions, improving clarity for users.
- Spelling Whitelist Expansion: The spelling allow list for GitHub Actions has been updated to include "deepwiki" and "tiangolo".
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces an [all] extra to simplify the installation of all optional dependencies, which is a great improvement for developers and testing environments. The changes also refactor the [sql] extra to be more modular and maintainable by depending on the individual database driver extras. The documentation in README.md has been updated accordingly.
My review includes a couple of minor suggestions:
- In
README.md, I've suggested removing an empty row in the installation table for better formatting. - In
pyproject.toml, I've recommended sorting the dependencies within the new[all]extra for improved readability and consistency.
Overall, these are solid changes that improve the project's dependency management.
| | **SQLite** | `uv add "a2a-sdk[sqlite]"` | `pip install "a2a-sdk[sqlite]"` | | ||
| | **All SQL Drivers** | `uv add "a2a-sdk[sql]"` | `pip install "a2a-sdk[sql]"` | | ||
| | **Encryption** | `uv add "a2a-sdk[encryption]"` | `pip install "a2a-sdk[encryption]"` | | ||
| | | | | |
There was a problem hiding this comment.
This empty row appears to be for visual spacing, but it can lead to inconsistent rendering across different Markdown viewers and makes the table source less clean. The subheading for 'Database Drivers' on the next line already provides good logical separation. Consider removing this empty row for a more standard and compact table.
| "a2a-sdk[http-server]", | ||
| "a2a-sdk[sql]", | ||
| "a2a-sdk[encryption]", | ||
| "a2a-sdk[grpc]", | ||
| "a2a-sdk[telemetry]", |
There was a problem hiding this comment.
For better readability and easier maintenance, it's a good practice to keep lists of dependencies sorted alphabetically. Consider sorting the extras within the all group.
| "a2a-sdk[http-server]", | |
| "a2a-sdk[sql]", | |
| "a2a-sdk[encryption]", | |
| "a2a-sdk[grpc]", | |
| "a2a-sdk[telemetry]", | |
| "a2a-sdk[encryption]", | |
| "a2a-sdk[grpc]", | |
| "a2a-sdk[http-server]", | |
| "a2a-sdk[sql]", | |
| "a2a-sdk[telemetry]", |
1 participant
No description provided.