style: add fix for TRY301 lint errors#401
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This PR addresses TRY301 linting errors by refactoring error handling and post-processing logic in several asynchronous request handlers. Specifically, raise ServerError calls and subsequent result processing are moved out of try blocks to ensure they are not inadvertently caught by broad except Exception clauses, leading to clearer and more explicit error management.
Highlights
- Error Handling Refactoring: Restructured on_message_send in default_request_handler.py to move ServerError raises and related post-processing logic outside the try...except block, ensuring specific error handling is not masked by a general exception catch.
- JSON-RPC Handler Updates: Applied similar refactoring to on_cancel_task and on_get_task within jsonrpc_handler.py, relocating success response preparation and TaskNotFoundError raises to occur after the main try...except block.
- Lint Rule Compliance: Fixed TRY301 lint errors by ensuring raise statements are not directly within try blocks that have a generic except Exception clause, promoting more precise exception handling.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the code to fix TRY301 lint errors. The changes involve moving raise ServerError(...) statements out of try blocks to avoid them being caught by broad except clauses.
The modifications in src/a2a/server/request_handlers/default_request_handler.py correctly move the result validation logic outside the try...finally block. This not only resolves the lint issue but also makes the Agent execution failed log message more precise, as it now only triggers for exceptions during the agent's event consumption.
Similarly, the changes in src/a2a/server/request_handlers/jsonrpc_handler.py for on_cancel_task and on_get_task correctly refactor the error handling for cases where a task is not found, preserving the original logic while adhering to linting rules.
Overall, the changes are well-implemented, targeted, and improve code quality. I have no further comments.
https://docs.astral.sh/ruff/rules/raise-within-try/