Skip to content

fix: Use HasField for simple message retrieval for grpc transport #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pstephengoogle merged 3 commits into from
Aug 4, 2025
Merged

fix: Use HasField for simple message retrieval for grpc transport #380

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85bcf6f
fix: Use HasField for simple message retrieval for grpc transport
timn Aug 4, 2025
545acd3
feat: Add test for send_message that returns a Message
timn Aug 4, 2025
9b17a81
Merge branch 'main' into timn/fix-grpc-sendmessage-result
pstephengoogle Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/a2a/client/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async def send_message(
metadata=proto_utils.ToProto.metadata(request.metadata),
)
)
if response.task:
if response.HasField('task'):
return proto_utils.FromProto.task(response.task)
return proto_utils.FromProto.message(response.msg)
Comment thread
timn marked this conversation as resolved.

Expand Down
Loading