Skip to content

feat: Add metadata as parameter to TaskUpdater.update_status() #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
holtskinner merged 2 commits into from
Jul 31, 2025
Merged

feat: Add metadata as parameter to TaskUpdater.update_status() #371

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c212508
feat: Add `metadata` as parameter to `TaskUpdater.update_status()`
holtskinner Jul 31, 2025
136ae79
Add docstring
holtskinner Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/a2a/server/tasks/task_updater.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,13 @@
TaskState.rejected,
}

async def update_status(

Check failure on line 46 in src/a2a/server/tasks/task_updater.py

View workflow job for this annotation

GitHub Actions / Lint Code Base

Ruff (D417) 

src/a2a/server/tasks/task_updater.py:46:15: D417 Missing argument description in the docstring for `update_status`: `metadata`
self,
state: TaskState,
message: Message | None = None,
final: bool = False,
timestamp: str | None = None,
metadata: dict[str, Any] | None = None,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The docstring for the update_status method should be updated to include a description for the new metadata parameter. This improves maintainability and helps other developers understand its purpose.

) -> None:
"""Updates the status of the task and publishes a `TaskStatusUpdateEvent`.

Expand Down Expand Up @@ -77,6 +78,7 @@
task_id=self.task_id,
context_id=self.context_id,
final=final,
metadata=metadata,
status=TaskStatus(
state=state,
message=message,
Expand Down
Loading