style: Formatting/Lint fixes#368
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on applying style and linting fixes across the codebase. It updates the formatting script to use a more comprehensive fix command for Ruff and addresses specific linting issues in a Python file by adjusting noqa directives. Additionally, it includes a reordering of imports in a test file, likely due to automated formatting.
Highlights
- Updated Ruff Command: The
scripts/format.shscript was updated to useruff check --fixinstead ofruff check --fix-only. This change likely enables Ruff to apply a broader range of automatic fixes during the formatting process. - Ruff NoQA Directives: In
src/a2a/server/tasks/database_push_notification_config_store.py, an inline# noqa: PLC0415was removed fromcryptography.fernetimports, and a file-level# ruff: noqa: PLC0415was added at the top of the file. This centralizes the suppression of thePLC0415rule (which is about moving imports to the top of the file) for this specific file. - Import Reordering: In
tests/test_types.py, several type imports were reordered. This is typically a result of an automated formatting tool enforcing a consistent import order.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request applies formatting and linting fixes across the codebase. The changes include updating a deprecated ruff command in the formatting script, consolidating a noqa directive to the file level for better maintainability, and reordering imports for consistency. All changes are appropriate and improve code style and tooling usage. The pull request is good to merge.
No description provided.