Skip to content

feat(spec): Update A2A types from specification 🤖#350

Merged
holtskinner merged 2 commits intomainfrom
auto-update-a2a-types-ef4a30505381e99b20103724cabef024389bacef
Jul 25, 2025
Merged

feat(spec): Update A2A types from specification 🤖#350
holtskinner merged 2 commits intomainfrom
auto-update-a2a-types-ef4a30505381e99b20103724cabef024389bacef

Conversation

@a2a-bot
Copy link
Copy Markdown
Collaborator

@a2a-bot a2a-bot commented Jul 25, 2025

This PR updates src/a2a/types.py based on the latest specification/json/a2a.json from a2aproject/A2A.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request incorporates updates from the latest A2A specification, primarily by introducing a new AgentCardSignature type and integrating it into the AgentCard structure. This enhancement enables the representation and handling of JSON Web Signatures for agent cards within the system's type definitions.

Highlights

  • New Type Definition: Introduced a new AgentCardSignature class to represent JSON Web Signatures (JWS) for AgentCards. This class includes fields for protected (Base64url-encoded JWS header), signature (computed signature), and an optional header (unprotected JWS header values).
  • AgentCard Enhancement: The AgentCard type has been updated to include a new optional field named signatures, which is a list of AgentCardSignature objects. This allows for the attachment of multiple JWS signatures to an AgentCard.
  • Automated Specification Update: This pull request is an automated update, reflecting the latest changes from the A2A specification, ensuring that the local type definitions remain synchronized with the upstream source.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the A2A types from the specification, adding the AgentCardSignature class and a signatures field to the AgentCard class. Reviewers should ensure that the new field is correctly handled throughout the codebase.

Comment thread src/a2a/grpc/a2a_pb2.py
Comment thread src/a2a/grpc/a2a_pb2.py
Comment thread src/a2a/grpc/a2a_pb2.pyi
Comment thread src/a2a/grpc/a2a_pb2.pyi
Comment thread src/a2a/grpc/a2a_pb2.pyi
Comment thread src/a2a/types.py
Comment thread src/a2a/types.py
@holtskinner holtskinner enabled auto-merge (squash) July 25, 2025 18:24
@holtskinner holtskinner merged commit 274a661 into main Jul 25, 2025
8 checks passed
@holtskinner holtskinner deleted the auto-update-a2a-types-ef4a30505381e99b20103724cabef024389bacef branch July 25, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants