feat(spec): Update A2A types from specification 🤖#350
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request incorporates updates from the latest A2A specification, primarily by introducing a new AgentCardSignature type and integrating it into the AgentCard structure. This enhancement enables the representation and handling of JSON Web Signatures for agent cards within the system's type definitions.
Highlights
- New Type Definition: Introduced a new
AgentCardSignatureclass to represent JSON Web Signatures (JWS) for AgentCards. This class includes fields forprotected(Base64url-encoded JWS header),signature(computed signature), and an optionalheader(unprotected JWS header values). - AgentCard Enhancement: The
AgentCardtype has been updated to include a new optional field namedsignatures, which is a list ofAgentCardSignatureobjects. This allows for the attachment of multiple JWS signatures to an AgentCard. - Automated Specification Update: This pull request is an automated update, reflecting the latest changes from the A2A specification, ensuring that the local type definitions remain synchronized with the upstream source.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the A2A types from the specification, adding the AgentCardSignature class and a signatures field to the AgentCard class. Reviewers should ensure that the new field is correctly handled throughout the codebase.
This PR updates
src/a2a/types.pybased on the latestspecification/json/a2a.jsonfrom a2aproject/A2A.