Skip to content

test: Correct JSON-RPC serialization tests and add edge case coverage#283

Merged
holtskinner merged 6 commits intoa2aproject:mainfrom
pankaj-bind:jsonrpc-serialization-tests
Jul 9, 2025
Merged

test: Correct JSON-RPC serialization tests and add edge case coverage#283
holtskinner merged 6 commits intoa2aproject:mainfrom
pankaj-bind:jsonrpc-serialization-tests

Conversation

@pankaj-bind
Copy link
Copy Markdown
Contributor

Description

This update addresses a failing test in tests/server/apps/jsonrpc/test_serialization.py and significantly enhances the test coverage for the JSON-RPC serialization layer to ensure robustness against various edge cases.

The test_handle_unicode_characters test was previously failing due to an invalid JSON-RPC request payload. This has been corrected to use a valid message/send request, allowing the test to properly validate Unicode handling.

Additionally, new tests have been added to cover scenarios that were previously untested:

  • Malformed JSON: Ensures the server correctly identifies and rejects invalid JSON structures, returning a JSONParseError.
  • Oversized Payloads: Checks how the application handles requests that exceed size limits, now gracefully handled as an InvalidRequestError.
  • Unicode Characters: The corrected test now properly validates that the application can handle Unicode characters in request payloads without serialization issues.

A minor improvement was also made to src/a2a/server/apps/jsonrpc/jsonrpc_app.py to explicitly catch HTTPException (like the one for oversized payloads) and convert it into a standard JSON-RPC error response, ensuring consistent error reporting to clients.

These changes ensure more robust and reliable JSON-RPC communication, which is critical for agentic applications.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format)
  • Appropriate docs were updated (if necessary)

@pankaj-bind pankaj-bind requested a review from a team as a code owner July 7, 2025 18:53
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @pankaj-bind, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and reliability of the JSON-RPC communication layer. It addresses a failing test, adds comprehensive test coverage for critical edge cases like malformed JSON and oversized payloads, and improves the server's error handling to provide consistent JSON-RPC error responses for HTTP-level issues.

Highlights

  • Test Correction: The test_handle_unicode_characters test in tests/server/apps/jsonrpc/test_serialization.py was fixed by correcting its JSON-RPC request payload to be valid, allowing it to properly validate Unicode handling.
  • New Test Coverage (Malformed JSON): Added a new test, test_handle_invalid_json, to ensure the server correctly identifies and rejects invalid JSON structures, returning a JSONParseError.
  • New Test Coverage (Oversized Payloads): Introduced test_handle_oversized_payload to check how the application handles requests that exceed size limits, expecting either a 413 HTTP status or a graceful JSON-RPC InvalidRequestError.
  • Enhanced Test Coverage (Unicode Characters): The test_handle_unicode_characters test was enhanced to properly validate that the application can handle Unicode characters in request payloads without serialization issues, using a more realistic message/send request.
  • Improved Error Handling: Modified src/a2a/server/apps/jsonrpc/jsonrpc_app.py to explicitly catch HTTPException (specifically for 413 Payload Too Large errors) and convert it into a standard JSON-RPC InvalidRequestError response, ensuring consistent error reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a failing test for Unicode handling and enhances test coverage for malformed JSON and oversized payloads. The application change to handle oversized payloads gracefully with a JSON-RPC error is a good improvement. The review suggests using named constants for HTTP status codes and making the oversized payload test more specific.

Comment thread tests/server/apps/jsonrpc/test_serialization.py Outdated
Comment thread src/a2a/server/apps/jsonrpc/jsonrpc_app.py Outdated
@holtskinner holtskinner changed the title fix(tests): Correct JSON-RPC serialization tests and add edge case coverage test: Correct JSON-RPC serialization tests and add edge case coverage Jul 7, 2025
@holtskinner holtskinner merged commit 07e9b84 into a2aproject:main Jul 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants