fix: unify chain-id defaults across all commands#2
Open
ai-virtual-b wants to merge 2 commits into
Open
Conversation
Owner
|
there shouldnt be a default, job should be initiated based on where the seller agent supported chain |
Buyer and seller commands hardcoded "8453" (Base mainnet) while job and message commands hardcoded "84532" (Base Sepolia). This mismatch could silently send transactions to the wrong chain. All commands now read chain-id from: --chain-id flag → ACP_CHAIN_ID env var → hardcoded "84532" default, via a shared getDefaultChainId() helper. Updated docs to reflect that ACP_CHAIN_ID applies to all commands. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ai-virtual-b
force-pushed
the
fix/consistent-chain-id-defaults
branch
from
bea6a0f to
cc2c5a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8453(Base mainnet) while job and message commands hardcoded84532(Base Sepolia). This could silently send transactions to the wrong chain.ACP_CHAIN_IDenv var now applies to all commands: previously it was only used for agent token resolution inclient.ts. All commands now respect it via a sharedgetDefaultChainId()helper.--chain-idflag →ACP_CHAIN_IDenv var →84532hardcoded defaultChanges
src/lib/defaults.tswithgetDefaultChainId()helperbuyer.ts,seller.ts,job.ts,message.ts,client.tsto use the helperREADME.mdandSKILL.mdto clarifyACP_CHAIN_IDapplies to all commandsTest plan
acp buyer create-job --helpshows84532as default (not8453)ACP_CHAIN_ID=1overrides the default for all commands--chain-idflag still takes precedence over env var🤖 Generated with Claude Code