This repository was archived by the owner on Aug 3, 2021. It is now read-only.
Fixed inconsistencies between instructions and answers.#154
Open
martianmad wants to merge 2 commits into
Open
Conversation
Author
|
I also put a space between immutable variables when deploying the contract. It seems odd to have different structure here of spaces and no spaces for mutable. |
teye
reviewed
May 13, 2020
teye
left a comment
teye
left a comment
Contributor
There was a problem hiding this comment.
It is good.
Could you edit this line: src/locales/instructions/en/chapter1/index.ts:220
Declare a new variable with the name `newname` and type `String` and give it a value `Bob`.
to
Declare a new variable with the name `newname` of type `String` and give it a value `Bob`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throughout the code example, the instructions and the accepted answers there were inconsistencies of how the code should be structured. This PR cleans up Chapter 1 to fix those inconsistencies and in 1 case, an error in the example code.